| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Subject: | Re: logical replication of truncate command with trigger causes Assert |
| Date: | 2021-06-12 07:15:28 |
| Message-ID: | CAA4eK1KkSpzioy4RwuiyQb_CrQ2URHSPShHTAEPswr25gX0r9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > On Fri, Jun 11, 2021 at 12:20 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Another thing
> >> I'm wondering is how many of these messages really need to be
> >> translated. We could use errmsg_internal and avoid burdening the
> >> translators, perhaps.
>
> > Not sure but I see all existing similar ereport calls don't use errmsg_internal.
>
> I was thinking maybe we could mark all these replication protocol
> violation errors non-translatable. While we don't want to crash on a
> protocol violation, it shouldn't really be a user-facing case either.
>
I don't see any problem with that as these are not directly related to
any user operation. So, +1 for making these non-translatable.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-12 07:22:23 | Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command |
| Previous Message | Darafei Komяpa Praliaskouski | 2021-06-12 06:55:13 | Re: Questions about support function and abbreviate |