| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Subject: | Re: logical replication of truncate command with trigger causes Assert |
| Date: | 2021-06-12 17:01:02 |
| Message-ID: | 2321999.1623517262@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I was thinking maybe we could mark all these replication protocol
>> violation errors non-translatable. While we don't want to crash on a
>> protocol violation, it shouldn't really be a user-facing case either.
> I don't see any problem with that as these are not directly related to
> any user operation. So, +1 for making these non-translatable.
Done that way. On re-reading the code, there were a bunch more
Asserts that could be triggered by bad input data, so the committed
patch has rather more corrections than I posted before.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-12 17:07:58 | Re: Race condition in recovery? |
| Previous Message | Justin Pryzby | 2021-06-12 16:13:15 | [PATCH] check_random_seed: use a boolean not an int.. |