| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Subject: | Re: logical replication of truncate command with trigger causes Assert |
| Date: | 2021-06-11 15:26:41 |
| Message-ID: | 1882577.1623425201@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Fri, Jun 11, 2021 at 12:20 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Another thing
>> I'm wondering is how many of these messages really need to be
>> translated. We could use errmsg_internal and avoid burdening the
>> translators, perhaps.
> Not sure but I see all existing similar ereport calls don't use errmsg_internal.
I was thinking maybe we could mark all these replication protocol
violation errors non-translatable. While we don't want to crash on a
protocol violation, it shouldn't really be a user-facing case either.
Thoughts?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-11 15:31:15 | Re: [PATCH] Fix select from wrong table array_op_test |
| Previous Message | Tom Lane | 2021-06-11 15:23:27 | Re: Race condition in recovery? |