Re: Introduce wait_for_subscription_sync for TAP tests

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce wait_for_subscription_sync for TAP tests
Date: 2022-08-03 04:51:15
Message-ID: CAA4eK1+X_R5=YhRmpREkS1i9z9KuxroLi-0dkh+1sPduibzAiw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 30, 2022 at 12:25 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Jul 28, 2022 at 6:37 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Wed, Jul 27, 2022 at 7:08 PM shiy(dot)fnst(at)fujitsu(dot)com
> > <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > I've attached updated patches that incorporated the above comments as
> > well as the comment from Amit.
> >
> > BTW regarding 0001 patch to remove the duplicated wait, should we
> > backpatch to v15?
> >
>
> I think it is good to clean this test case even for PG15 even though
> there is no major harm in keeping it. I'll push this early next week
> by Tuesday unless someone thinks otherwise.
>

Pushed this one and now I'll look at your other patch.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-08-03 04:52:07 Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together.
Previous Message Masahiko Sawada 2022-08-03 04:06:25 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns