From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
---|---|
To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
Cc: | Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: json(b)_to_tsvector with numeric values |
Date: | 2018-04-02 10:29:20 |
Message-ID: | CA+q6zcVpRdy-UL2TVm05H-aSNy8hHLULO8Db=9VTj_=MPjt3wg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 2 April 2018 at 11:27, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
> On Mon, Apr 02, 2018 at 11:41:12AM +0300, Oleg Bartunov wrote:
>> On Mon, Apr 2, 2018 at 9:45 AM, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>> I found this bug, when working on presentation about FTS and it looked
>> annoying, since it validates
>> the consistency of FTS.I think this is a bug, which needs to be fixed,
>> else inconsistency with existing full text search will be gets
>> deeper.
>>
>> The fix looks trivial, but needs a review, of course.
>
> Oh, I understood. The code looks good, tests passed. But maybe it is
> better to use NumericGetDatum() instead of PointerGetDatum()?
Well, technically speaking they're the same, but yes, NumericGetDatum would be
more precise. I've modified it in the attached patch.
Attachment | Content-Type | Size |
---|---|---|
jsonb_to_tsvector_numeric_v2.patch | application/octet-stream | 5.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2018-04-02 11:57:09 | Re: Diagonal storage model |
Previous Message | Amit Langote | 2018-04-02 09:49:57 | Re: [HACKERS] Add support for tuple routing to foreign partitions |