Re: json(b)_to_tsvector with numeric values

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Oleg Bartunov <obartunov(at)postgrespro(dot)ru>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: json(b)_to_tsvector with numeric values
Date: 2018-04-02 09:27:30
Message-ID: 20180402092729.GA1811@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Apr 02, 2018 at 11:41:12AM +0300, Oleg Bartunov wrote:
> On Mon, Apr 2, 2018 at 9:45 AM, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
> I found this bug, when working on presentation about FTS and it looked
> annoying, since it validates
> the consistency of FTS.I think this is a bug, which needs to be fixed,
> else inconsistency with existing full text search will be gets
> deeper.
>
> The fix looks trivial, but needs a review, of course.

Oh, I understood. The code looks good, tests passed. But maybe it is
better to use NumericGetDatum() instead of PointerGetDatum()?

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2018-04-02 09:32:53 Re: [HACKERS] [PATCH] Lockable views
Previous Message Alexander Lakhin 2018-04-02 09:12:12 make installcheck-world in a clean environment