| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: xid wraparound danger due to INDEX_CLEANUP false |
| Date: | 2020-05-05 22:17:48 |
| Message-ID: | CA+fd4k6ysRsi7qhxORwLyv58Nq7=R7vU8qCEPBrDW+0ZD3ACNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 6 May 2020 at 07:14, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Tue, May 5, 2020 at 2:52 PM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> > So IIUC the problem is that since we skip both,
> > oldst_btpo_xact could be seen as a "future" xid during vacuum. Which
> > will be a cause of that vacuum misses pages which can actually be
> > recycled.
>
> This is also my understanding of the problem.
>
> > I think we can fix this issue by calling vacuumcleanup callback when
> > an anti-wraparound vacuum even if INDEX_CLEANUP is false. That way we can
> > let index AM make decisions whether doing cleanup index at least once
> > until XID wraparound, same as before.
>
> +1
>
> Can you work on a patch?
Yes, I'll submit a bug fix patch.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2020-05-05 22:48:28 | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Previous Message | Juan José Santamaría Flecha | 2020-05-05 22:17:03 | Re: Postgres Windows build system doesn't work with python installed in Program Files |