| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: xid wraparound danger due to INDEX_CLEANUP false |
| Date: | 2020-05-05 22:13:56 |
| Message-ID: | CAH2-Wz=WWY5RS7sKMa51urv_r-ApZftWLZkZ8Ek6mVaUJdMXkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 5, 2020 at 2:52 PM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> So IIUC the problem is that since we skip both,
> oldst_btpo_xact could be seen as a "future" xid during vacuum. Which
> will be a cause of that vacuum misses pages which can actually be
> recycled.
This is also my understanding of the problem.
> I think we can fix this issue by calling vacuumcleanup callback when
> an anti-wraparound vacuum even if INDEX_CLEANUP is false. That way we can
> let index AM make decisions whether doing cleanup index at least once
> until XID wraparound, same as before.
+1
Can you work on a patch?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2020-05-05 22:17:03 | Re: Postgres Windows build system doesn't work with python installed in Program Files |
| Previous Message | Masahiko Sawada | 2020-05-05 21:51:35 | Re: xid wraparound danger due to INDEX_CLEANUP false |