Re: PG compilation error with Visual Studio 2015/2017/2019

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-05-05 22:48:28
Message-ID: CAC+AXB26dVS8-4JK-w18ufRWgf8KJ2cOEzODkU65igZUaXzs0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 5, 2020 at 1:34 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

>
> Apart from that, I have made a few other changes in comments, fixed
> typos, and ran pgindent. Let me know what do you think of attached
> patches?
>

The patches are definitely in better shape.

I think that the definition of get_iso_localename() should be consistent
across all versions, that is HEAD like back-patched.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-05-05 23:21:55 Re: Unify drop-by-OID functions
Previous Message Masahiko Sawada 2020-05-05 22:17:48 Re: xid wraparound danger due to INDEX_CLEANUP false