From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
Date: | 2017-01-14 04:36:05 |
Message-ID: | CA+HiwqHtXOnM=Ty1UNkSOT-6274q8LRhHsSRn4eEFuuYMObv+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Sat, Jan 14, 2017 at 6:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jan 13, 2017 at 3:09 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>> I'm just saying that the problem at hand is already solved for a related
>> feature, so ISTM this new code should use the recently added routine
>> rather than doing the same thing in a different way.
>
> Oh, I see. Amit, thoughts?
Hm, perhaps. The code in map_partition_varattnos() that creates the
map could be replaced by a call to the new
convert_tuples_by_name_map(). In fact, it could even have used the
old version of it (convert_tuples_by_name()). I guess I just aped
what other callers of map_variable_attnos() were doing, which is to
generate the map themselves (not that they ought to be changed to use
convert_tuples_by_name_map).
I will send a patch at my earliest convenience. Thanks to Alvaro for
pointing that out.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-01-14 04:41:57 | Re: pgsql: Fix some more regression test row-order-instability issues. |
Previous Message | Peter Eisentraut | 2017-01-14 02:26:34 | pgsql: Updates to reflect that pg_ctl stop -m fast is the default |
From | Date | Subject | |
---|---|---|---|
Next Message | Serge Rielau | 2017-01-14 04:56:25 | Re: Packages: Again |
Previous Message | Tomas Vondra | 2017-01-14 00:36:18 | Re: Protect syscache from bloating with negative cache entries |