On 2017/01/14 13:36, Amit Langote wrote:
> On Sat, Jan 14, 2017 at 6:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Jan 13, 2017 at 3:09 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>> I'm just saying that the problem at hand is already solved for a related
>>> feature, so ISTM this new code should use the recently added routine
>>> rather than doing the same thing in a different way.
>> Oh, I see. Amit, thoughts?
> Hm, perhaps. The code in map_partition_varattnos() that creates the
> map could be replaced by a call to the new
> convert_tuples_by_name_map(). In fact, it could even have used the
> old version of it (convert_tuples_by_name()). I guess I just aped
> what other callers of map_variable_attnos() were doing, which is to
> generate the map themselves (not that they ought to be changed to use
> I will send a patch at my earliest convenience. Thanks to Alvaro for
> pointing that out.
And here is the patch.
In response to
pgsql-hackers by date
|Next:||From: Michael Paquier||Date: 2017-01-16 06:08:28|
|Subject: Re: An isolation test for SERIALIZABLE READ ONLY DEFERRABLE|
|Previous:||From: Michael Paquier||Date: 2017-01-16 05:47:51|
|Subject: Re: Patch to implement pg_current_logfile() function|
pgsql-committers by date
|Next:||From: Fujii Masao||Date: 2017-01-16 09:56:14|
|Subject: pgsql: Fix typos in comments.|
|Previous:||From: Tom Lane||Date: 2017-01-15 19:09:45|
|Subject: pgsql: Fix matching of boolean index columns to sort ordering.|