From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
Date: | 2017-01-13 21:10:02 |
Message-ID: | CA+Tgmobh_cVzo6R+UhM-G6sM_-NLfVYmW8iUZPGQgn0gS5amLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 13, 2017 at 3:09 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Robert Haas wrote:
>> On Fri, Jan 13, 2017 at 2:31 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> > On Fri, Jan 13, 2017 at 2:18 PM, Alvaro Herrera
>> > <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> >> Hmm, we were discussing this stuff a few days ago, see
>> >> https://www.postgresql.org/message-id/20170109182800.qrkae62kmur3gfeg@alvherre.pgsql
>> >> and commit 3957b58b8885441c8d03bc1cfc00e47cf8cd7975. Part of this code
>> >> duplicates that ...
>> >
>> > Is that bad?
>>
>> If you are expressing a concern about who wrote this code, I took
>> Amit's word for it that he did.
>
> I'm just saying that the problem at hand is already solved for a related
> feature, so ISTM this new code should use the recently added routine
> rather than doing the same thing in a different way.
Oh, I see. Amit, thoughts?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-01-13 21:21:38 | pgsql: pg_upgrade: Fix for changed pg_ctl default stop mode |
Previous Message | Alvaro Herrera | 2017-01-13 20:09:57 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
From | Date | Subject | |
---|---|---|---|
Next Message | Serge Rielau | 2017-01-13 21:16:43 | Re: Packages: Again |
Previous Message | Peter van Hardenberg | 2017-01-13 21:09:36 | Re: GSoC 2017 |