Re: pgsql: Fix some more regression test row-order-instability issues.

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix some more regression test row-order-instability issues.
Date: 2017-01-14 04:41:57
Message-ID: CA+HiwqFPjfvxhCuyoYHH_yETdiPrOZyVy17sorv99d30Rz=Mxg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Jan 14, 2017 at 7:32 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fix some more regression test row-order-instability issues.
>
> Commit 0563a3a8b just introduced another instance of the same unsafe
> testing methodology that appeared in 2ac3ef7a0, which I corrected in
> 257d81572. Robert/Amit, please stop doing that.
>
> Also look through the rest of f0e44751d's test cases, and correct some
> other queries with underdetermined ordering of results from the system
> catalogs. These haven't failed in the buildfarm yet, but I don't
> have any confidence in that staying true.

Sorry about that. I should have taken a cue from the last time you
fixed one of these, will be careful henceforth.

Thanks,
Amit

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-01-14 14:18:32 pgsql: pg_ctl: Change default to wait for all actions
Previous Message Amit Langote 2017-01-14 04:36:05 Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints.