| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "brar(at)gmx(dot)de" <brar(at)gmx(dot)de>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value |
| Date: | 2026-10-31 11:32:00 |
| Message-ID: | 9bcab85a-edda-4302-bdd0-1c1cf5b7a66c@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On Mon, Oct 26, 2026 at 10:56 AM "Hayato Kuroda (Fujitsu)" wrote:
>
>> Attached is a patch that uses defGetString() for "proto_version" and
>> "publication_names" and adds a simple test in 030_pg_recvlogical.pl
>> to confirm it works.
>
> Thanks for the patch. One question:
>
> ```
> if (parsed > PG_UINT32_MAX)
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("proto_version \"%s\" out of range",
> strVal(defel->arg))));
> ```
>
> Here strVal() is still used, but I feel it's better to refer `val` here. We can completely remove
> the function call.
Thanks for reviewing.
Here is the V2 patch.
--
Best Regards,
Zhijie Hou
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-pgoutput-crash-on-missing-option-values.patch | text/plain | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Speller | 2026-11-01 01:26:26 | Lost walsender wakeup stalls synchronous commits until the standby's next reply (16+) |
| Previous Message | Zhijie Hou | 2026-10-31 11:31:20 | Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value |