| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "brar(at)gmx(dot)de" <brar(at)gmx(dot)de>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value |
| Date: | 2026-10-31 11:31:20 |
| Message-ID: | 34348588-9b17-4b9b-a069-11f106cdc32a@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On Wed, Oct 28, 2026 at 01:36 AM Kirill Reshke wrote:
> Looks like a real issue. I reviewed a patch, I think this is a natural
> follow-up for [0]. the CREATE_REPLICATION_SLOT/ALTER_REPLICATION_SLOT
> option parser only uses defGetString/defGetBoolean - pgoutput is the
> only crasher.
>
> Also, should we reject option like
>
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("option \"%s\" requires a value",
> "publication_names")));
>
>
> instead of a generic error message from defGetString?
I think a special message is unnecessary here, especially since we don't
do that in other replication parsing code, so I've kept the current version.
--
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou | 2026-10-31 11:32:00 | Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value |
| Previous Message | shihao zhong | 2026-10-31 04:49:22 | Re: Wrong results: hashed SubPlan referenced twice after OR-qual extraction reuses a stale hash table (13 to 19beta4) |