| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Zhijie Hou' <houzhijie22(at)gmail(dot)com> |
| Cc: | "brar(at)gmx(dot)de" <brar(at)gmx(dot)de>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value |
| Date: | 2026-10-26 02:56:10 |
| Message-ID: | OS7PR01MB18317FEB9D24DE47C5077EF90F5612@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
> Attached is a patch that uses defGetString() for "proto_version" and
> "publication_names" and adds a simple test in 030_pg_recvlogical.pl
> to confirm it works.
Thanks for the patch. One question:
```
if (parsed > PG_UINT32_MAX)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("proto_version \"%s\" out of range",
strVal(defel->arg))));
```
Here strVal() is still used, but I feel it's better to refer `val` here. We can completely remove
the function call.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-10-26 04:01:34 | Re: BUG #19784: "no relation entry for relid 1" when costing = ANY (<array expr over max(col)>) in a MinMaxAggPath |
| Previous Message | Michael Paquier | 2026-10-26 00:57:20 | Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction |