Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Zhijie Hou <houzhijie22(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "brar(at)gmx(dot)de" <brar(at)gmx(dot)de>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value
Date: 2026-11-01 08:00:31
Message-ID: aubxn5Ny_ehMhwdB@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Oct 31, 2026 at 07:32:00PM +0800, Zhijie Hou wrote:
> Thanks for reviewing.
>
> Here is the V2 patch.

Thanks for the patch, nice catch. I'll handle that and backpatch.
I regret missing that during the lookup of this code for 290bb8afe6b4,
especially as the crash was possible before it for the two code paths
you are pointing at with the two direct accesses to defel->arg.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2026-11-01 08:06:12 BUG #19823: JSON_VALUE(... RETURNING jsonb) silently returns NULL for PASSING values of NaN / Infinity; the expo
Previous Message PG Bug reporting form 2026-11-01 07:56:47 BUG #19822: DEFAULT boolean expressions in SQL/JSON functions are re-encoded as JSON booleans and always yield f