| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: The pgperltidy diffs in HEAD |
| Date: | 2025-11-25 21:03:02 |
| Message-ID: | 9a1d41f3-5ea5-42c3-9235-6e94448f95a8@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-11-25 Tu 2:36 PM, Daniel Gustafsson wrote:
>> On 25 Nov 2025, at 20:31, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>>
>> On 2025-Nov-25, Daniel Gustafsson wrote:
>>
>>> Agreed. Perhaps something like the attached would work?
>> Hmm, I got this
>>
>> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
>>
>> $ ls -l /bin/sh
>> lrwxrwxrwx 1 root root 4 feb 4 2025 /bin/sh -> dash*
>>
>> (Seems to work ok silently with bash.)
> If you replace the if statement with the one below using test, does that make
> it work?
>
> if test $? = 1; then
>
Looks to me like your original patch had == where it should have had =
Your formulation above corrects that.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-11-25 21:16:00 | Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent |
| Previous Message | Robert Haas | 2025-11-25 20:58:47 | Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent |