| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent |
| Date: | 2025-11-25 21:16:00 |
| Message-ID: | aSYckI8dlAx23HBe@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Nov 25, 2025 at 03:58:47PM -0500, Robert Haas wrote:
> On Tue, Nov 25, 2025 at 12:45 PM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
>> I gave your idea a try, and I like the result a lot. IMHO it makes the
>> code much easier to reason about.
>
> I looked through this and I agree this looks good. Thanks for working on it.
My tests seem happy, so I will plan on committing these patches tomorrow.
The only difference in v4 is that pg_get_dsm_registry_allocations() will no
longer show partially-initialized entries. I thought that was the best
option in this case because such entries shouldn't have any allocated
memory, and retrying GetNamed*() would set *found to false.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Revert-Teach-DSM-registry-to-ERROR-if-attaching-t.patch | text/plain | 3.7 KB |
| v4-0002-handle-ERRORs-in-DSM-registry-functions.patch | text/plain | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-11-25 21:42:41 | pgsql: Assert that cutoffs are provided if freezing will be attempted |
| Previous Message | Robert Haas | 2025-11-25 20:58:47 | Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-11-25 21:23:04 | Re: Buffer locking is special (hints, checksums, AIO writes) |
| Previous Message | Andrew Dunstan | 2025-11-25 21:03:02 | Re: The pgperltidy diffs in HEAD |