Re: The pgperltidy diffs in HEAD

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: The pgperltidy diffs in HEAD
Date: 2025-11-25 19:36:33
Message-ID: CE1092EF-73D2-4605-9520-D6122AAF2568@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 25 Nov 2025, at 20:31, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Nov-25, Daniel Gustafsson wrote:
>
>> Agreed. Perhaps something like the attached would work?
>
> Hmm, I got this
>
> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
>
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 feb 4 2025 /bin/sh -> dash*
>
> (Seems to work ok silently with bash.)

If you replace the if statement with the one below using test, does that make
it work?

if test $? = 1; then

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-11-25 20:02:02 Re: Buffer locking is special (hints, checksums, AIO writes)
Previous Message Álvaro Herrera 2025-11-25 19:31:09 Re: The pgperltidy diffs in HEAD