| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
| Date: | 2017-08-29 02:26:24 |
| Message-ID: | 9701.1503973584@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> I don't like breaking the abstraction of pg_log() with the existing
> flags with some kind of pg_debug() layer. The set of APIs present now
> in pg_rewind for logging is nice to have, and I think that those debug
> messages should be translated. So what about the attached?
Your point about INT64_FORMAT not necessarily working with fprintf
is an outstanding reason not to keep it like it is. I've not reviewed
this patch in detail but I think this is basically the way to fix it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-29 13:34:40 | pgsql: Improve docs about numeric formatting patterns (to_char/to_numbe |
| Previous Message | Michael Paquier | 2017-08-29 02:22:12 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | yangjie | 2017-08-29 02:44:51 | Re: hash partitioning based on v10Beta2 |
| Previous Message | Michael Paquier | 2017-08-29 02:22:12 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |