| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
| Date: | 2017-08-30 22:16:59 |
| Message-ID: | CAB7nPqQD+mVqqjr8VhiTLv=JLm_ZfrFC4h-=pjmhFbWz9_1juA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Aug 29, 2017 at 11:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> I don't like breaking the abstraction of pg_log() with the existing
>> flags with some kind of pg_debug() layer. The set of APIs present now
>> in pg_rewind for logging is nice to have, and I think that those debug
>> messages should be translated. So what about the attached?
>
> Your point about INT64_FORMAT not necessarily working with fprintf
> is an outstanding reason not to keep it like it is. I've not reviewed
> this patch in detail but I think this is basically the way to fix it.
So, perhaps it would be better to fix that before the next point release?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-08-30 23:39:18 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
| Previous Message | Tom Lane | 2017-08-30 21:21:18 | pgsql: Code review for nodeGatherMerge.c. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-08-30 22:37:09 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Previous Message | Peter Geoghegan | 2017-08-30 22:14:35 | Re: The case for removing replacement selection sort |