Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Date: 2017-09-04 10:03:57
Message-ID: 20170904100357.n52nq4lm5wkrpxpi@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> > I don't like breaking the abstraction of pg_log() with the existing
> > flags with some kind of pg_debug() layer. The set of APIs present now
> > in pg_rewind for logging is nice to have, and I think that those debug
> > messages should be translated. So what about the attached?
> Your point about INT64_FORMAT not necessarily working with fprintf
> is an outstanding reason not to keep it like it is. I've not reviewed
> this patch in detail but I think this is basically the way to fix it.

Actually this code goes throgh vsnprintf, not fprintf, which should be
safe, so I removed that part of the comment, and pushed.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-04 17:45:27 pgsql: Adjust pgbench to allow non-ASCII characters in variable names.
Previous Message Alvaro Herrera 2017-09-04 09:11:21 pgsql: Fix translatable string

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2017-09-04 10:05:38 Re: Useless code in ExecInitModifyTable
Previous Message Amit Langote 2017-09-04 09:59:25 Re: Secondary index access optimizations