| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | shaobo zhang <zshaoo224(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix missing semicolon in pl_gram.y for option_value rule |
| Date: | 2026-06-09 17:03:49 |
| Message-ID: | 892846.1781024629@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
shaobo zhang <zshaoo224(at)gmail(dot)com> writes:
>> Why do we even need to care about that?
>> --
>> Michael
> Agreed, it's purely cosmetic. If there's no interest in this cleanup,
> I'm fine to withdraw it. Thanks both for looking.
My inner neatnik likes consistency, so in the abstract I'd rather have
the semicolon present. But I agree with Michael that it's not worth
the overhead to do this sort of fix retail. (BTW I've got little
confidence that there aren't other places needing the same fix.)
What I'd really like is an equivalent of pgindent for bison files,
so that we could enforce this sort of style rule automatically.
But I suppose that's more work than it's worth, too. Unless someone
knows of an existing tool?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-06-09 17:20:28 | Re: [PATCH] CI: Add a CPAN cache on Windows |
| Previous Message | Tom Lane | 2026-06-09 16:54:49 | Re: typedef struct WindowClause misleading comments |