Re: Fix missing semicolon in pl_gram.y for option_value rule

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, shaobo zhang <zshaoo224(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix missing semicolon in pl_gram.y for option_value rule
Date: 2026-06-10 13:44:45
Message-ID: 0ae7286a-e24f-4dd0-8a17-f34a2c257bbd@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.06.26 19:03, Tom Lane wrote:
> shaobo zhang <zshaoo224(at)gmail(dot)com> writes:
>>> Why do we even need to care about that?
>>> --
>>> Michael
>
>> Agreed, it's purely cosmetic. If there's no interest in this cleanup,
>> I'm fine to withdraw it. Thanks both for looking.
>
> My inner neatnik likes consistency, so in the abstract I'd rather have
> the semicolon present. But I agree with Michael that it's not worth
> the overhead to do this sort of fix retail. (BTW I've got little
> confidence that there aren't other places needing the same fix.)
>
> What I'd really like is an equivalent of pgindent for bison files,
> so that we could enforce this sort of style rule automatically.
> But I suppose that's more work than it's worth, too. Unless someone
> knows of an existing tool?

The release notes of bison 3.0 say

Missing semicolons at the end of actions are no longer added (as
announced
in the release 2.5).

But apparently that is not in fact happening?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-06-10 13:49:00 Re: ci: Generate crashlogs on Windows
Previous Message Peter Eisentraut 2026-06-10 13:34:45 Re: [PATCH] Fix compiler warnings by using designated initializers