Re: Extended test coverage and docs for SSL passphrase commands

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: Extended test coverage and docs for SSL passphrase commands
Date: 2025-11-23 19:56:35
Message-ID: 7FD6B3DB-E0CA-42B9-94CA-039AE55D964F@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 22 Nov 2025, at 14:00, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Nov-21, Daniel Gustafsson wrote:
>
>> The attached v2 adds a GUC debug_exec_backend which can be used to get the
>> state of the running cluster,
>
> Nice idea.
>
> I think the parallel to debug_assertions is not perfect, because you can
> turn off debug_assertions in a server built with them included, but you
> cannot turn off EXEC_BACKEND.

debug_assertions cannot be disabled anymore, since 3bdcf6a5a755.

> This says we shouldn't name the symbol
> with the DEFAULT word: it should just be "EXEC_BACKEND_ENABLED".

Regardless, I totally agree with that, fixed in the attached along with the
review comments from upthread.

--
Daniel Gustafsson

Attachment Content-Type Size
v2-0001-doc-Clarify-passphrase-command-reloading-on-Windo.patch application/octet-stream 2.5 KB
v2-0002-Add-GUC-to-show-EXEC_BACKEND-state.patch application/octet-stream 3.6 KB
v2-0003-ssl-Add-connection-and-reload-tests-for-key-passp.patch application/octet-stream 7.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-11-23 20:16:17 Re: Trying out <stdatomic.h>
Previous Message Daniel Gustafsson 2025-11-23 19:32:46 Re: Extended test coverage and docs for SSL passphrase commands