Re: Extended test coverage and docs for SSL passphrase commands

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: Extended test coverage and docs for SSL passphrase commands
Date: 2025-11-25 15:01:45
Message-ID: 255bae92-54a5-4a11-a723-ad9ddf2a8ae5@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23.11.25 20:56, Daniel Gustafsson wrote:
>> On 22 Nov 2025, at 14:00, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>>
>> On 2025-Nov-21, Daniel Gustafsson wrote:
>>
>>> The attached v2 adds a GUC debug_exec_backend which can be used to get the
>>> state of the running cluster,
>>
>> Nice idea.
>>
>> I think the parallel to debug_assertions is not perfect, because you can
>> turn off debug_assertions in a server built with them included, but you
>> cannot turn off EXEC_BACKEND.
>
> debug_assertions cannot be disabled anymore, since 3bdcf6a5a755.
>
>> This says we shouldn't name the symbol
>> with the DEFAULT word: it should just be "EXEC_BACKEND_ENABLED".
>
> Regardless, I totally agree with that, fixed in the attached along with the
> review comments from upthread.

This looks good to me.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-11-25 15:03:37 Re: reduce size of logs stored by buildfarm
Previous Message Peter Eisentraut 2025-11-25 14:55:12 Re: PRI?64 vs Visual Studio (2022)