| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Extended test coverage and docs for SSL passphrase commands |
| Date: | 2025-11-23 19:32:46 |
| Message-ID: | 55D58873-1507-4272-9402-B2110D84EB8D@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 22 Nov 2025, at 10:30, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> I just reviewed the patch and got a few comments.
Thanks! An updated version will come downthread.
> The GUC is added like a mirror of debug_assertions. However, I think a small difference is that, assertions will impact everything at runtime, while EXEC_BACKEND don’t really impact PG’s behavior, instead it only impacts how backend processes are spawned. Thus, I feel “running server is EXEC_BACKEND mode” is a little bit inaccurate, maybe just say “show whether the running server is built with EXEC_BACKEND”.
That's a good point, the docementation hunk had it right where this part got it
wrong. Fixed.
> This is not a comment. I’m just thinking that, as EXEC_BACKEND is compile flag, when a server is started, it knows if EXEC_BACKEND is enabled or not. So that, if ssl_passphrase_command must be turned on, why cannot we automatically turn on it?
Technically we might be able to, but I don't want to override the administrator
when it comes to sensitive configuration settings. Better to document what
needs to be done and have the user make informed decisions.
> Typo: passhprase -> passphrase
Fixed.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-11-23 19:56:35 | Re: Extended test coverage and docs for SSL passphrase commands |
| Previous Message | Álvaro Herrera | 2025-11-23 18:17:32 | Re: Trying out <stdatomic.h> |