| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: Extended test coverage and docs for SSL passphrase commands |
| Date: | 2025-11-24 17:08:24 |
| Message-ID: | 202511240947.5ekcze55nell@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Nov-23, Daniel Gustafsson wrote:
> > On 22 Nov 2025, at 14:00, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > I think the parallel to debug_assertions is not perfect, because you
> > can turn off debug_assertions in a server built with them included,
> > but you cannot turn off EXEC_BACKEND.
>
> debug_assertions cannot be disabled anymore, since 3bdcf6a5a755.
Hah, 2014 -- goes to show that I don't try very often ;-) (I do have a
separate build tree for no-assertions, which I don't use very often
either.)
> > This says we shouldn't name the symbol with the DEFAULT word: it
> > should just be "EXEC_BACKEND_ENABLED".
>
> Regardless, I totally agree with that, fixed in the attached along
> with the review comments from upthread.
This looks reasonable to me, thanks.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"No nos atrevemos a muchas cosas porque son difíciles,
pero son difíciles porque no nos atrevemos a hacerlas" (Séneca)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-11-24 17:18:34 | Re: Missing wait events (gap analysis) |
| Previous Message | Matthias van de Meent | 2025-11-24 17:05:34 | Re: Missing wait events (gap analysis) |