| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Alberto Piai <alberto(dot)piai(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |
| Date: | 2026-07-30 02:12:23 |
| Message-ID: | 7C002DB7-952F-4B9A-8A0E-07723A9FB0E7@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jul 30, 2026, at 01:07, Sami Imseih <samimseih(at)gmail(dot)com> wrote:
>
> Hi,
>
>> PFA v11 - addressed Sami’s comments on v10.
>
> Thanks!
>
> v11-0001 looks good with some minor comment changes on my end:
>
> v11-0002 also looks good. I renamed find_partition_index_properties
> to RememberPartitionIndexPropertiesForRebuilding
>
> Attached is a v12 with these minor fixes. I also improved the commit
> message for 0002.
>
> --
> Sami Imseih
> Amazon Web Services (AWS)
> <v12-0002-tablecmds-preserve-replica-identity-and-cluster-.patch><v12-0001-tablecmds-preserve-partition-index-names-during-.patch>
Thanks for updating the patch. V12 looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-07-30 02:22:31 | RE: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server |
| Previous Message | Peter Smith | 2026-07-30 01:59:10 | Re: PSQL schema "describe" \dn is not escaping quotes |