| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Steven Niu <niushiji(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PSQL schema "describe" \dn is not escaping quotes |
| Date: | 2026-07-30 01:59:10 |
| Message-ID: | CAHut+PvSVoYdPs=4doBAPQFkN3fq44ezMxq=JWCiks-4Rit8Pg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 29, 2026 at 7:58 PM Nishant Sharma
<nishant(dot)sharma(at)enterprisedb(dot)com> wrote:
>
> Thanks for the patch!
>
> Here are my review comments on v2:-
>
> 1) A test case is missing for the patch. You can add the same test you already shared.
Thanks for your review.
PSA v3. This is the same as v2, but now includes some test cases.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-escapes-for-psql-describe-schema-patterns.patch | application/octet-stream | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Ian Lawrence Barwick | 2026-07-30 01:27:32 | Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document |