RE: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Shlok Kyal' <shlok(dot)kyal(dot)oss(at)gmail(dot)com>
Cc: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: RE: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server
Date: 2026-07-30 02:22:31
Message-ID: OS9PR01MB12149AFD8BC942C0A613EFEB7F5C92@OS9PR01MB12149.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Shlok,

> Thanks for reviewing the patch. I have updated the patch and attached
> the v2 patch.

Thanks for the update. According to others, different kinds of statements should be
different else-if statements. So we may have to be something like below:

```
else if (stmt->kind == ALTER_SUBSCRIPTION_REFRESH_PUBLICATION)
{
...
}
else if (stmt->kind == ALTER_SUBSCRIPTION_ADD_PUBLICATION ||
stmt->kind == ALTER_SUBSCRIPTION_DROP_PUBLICATION ||
stmt->kind == ALTER_SUBSCRIPTION_SET_PUBLICATION)
{
if (IsSet(opts.specified_opts, SUBOPT_REFRESH) && opts.refresh)
...
}
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2026-07-30 02:48:49 pg19b1: stuck in LockBuffer
Previous Message Chao Li 2026-07-30 02:12:23 Re: tablecmds: fix bug where index rebuild loses replica identity on partitions