| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Alberto Piai <alberto(dot)piai(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |
| Date: | 2026-07-29 17:07:08 |
| Message-ID: | CAA5RZ0s53T_gapFSE4qDH31+w0OFkHioYor_bu2kGy6cpZNVvw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> PFA v11 - addressed Sami’s comments on v10.
Thanks!
v11-0001 looks good with some minor comment changes on my end:
v11-0002 also looks good. I renamed find_partition_index_properties
to RememberPartitionIndexPropertiesForRebuilding
Attached is a v12 with these minor fixes. I also improved the commit
message for 0002.
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0002-tablecmds-preserve-replica-identity-and-cluster-.patch | application/octet-stream | 28.8 KB |
| v12-0001-tablecmds-preserve-partition-index-names-during-.patch | application/octet-stream | 18.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-07-29 17:56:41 | Re: [PATCH] Batched clock sweep to reduce cross-socket atomic contention |
| Previous Message | Mihail Nikalayeu | 2026-07-29 17:01:00 | Re: [SP-]GiST IOS visibility bug (was: Why doens't GiST require super-exclusive lock) |