| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-05-22 14:28:58 |
| Message-ID: | 55087f39-c7d5-4d26-80ff-51868e998985@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/5/2025 16:17, Robert Haas wrote:
> On Sat, May 3, 2025 at 2:44 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>> I have one additional proposal.
>>
>> I currently use this interface and have noticed that the parameter
>> `option_name` in the RegisterExtensionExplainOption routine is
>> case-sensitive. Since SQL treats our extended options as
>> case-insensitive, it would be beneficial to either add a comment
>> clarifying this behavior or forcedly convert incoming text constant to
>> lowercase.
>
> I don't think this is really true. It's just standard identifier
> handling. You can have options with upper-case names if you quote
> them.
Sorry for my language. I meant that when you call function
RegisterExtensionExplainOption(), it make sense if you write parameter
`option_name` as "debug" or "deBug". On the user side
case-insensitiveness works correctly, of course. Not sure about side
effects if one extension will call this routine with "Debug" parameter
and another one - "debuG".
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-05-22 14:30:40 | Re: Statistics Import and Export |
| Previous Message | Melanie Plageman | 2025-05-22 14:26:49 | Re: Assert("vacrel->eager_scan_remaining_successes > 0") |