| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-05-22 14:17:05 |
| Message-ID: | CA+Tgmob_cLoLdTnydXFNuR5ns_WWMDQSk5-ZM9kdoL6=+BXpQA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 3, 2025 at 2:44 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> I have one additional proposal.
>
> I currently use this interface and have noticed that the parameter
> `option_name` in the RegisterExtensionExplainOption routine is
> case-sensitive. Since SQL treats our extended options as
> case-insensitive, it would be beneficial to either add a comment
> clarifying this behavior or forcedly convert incoming text constant to
> lowercase.
I don't think this is really true. It's just standard identifier
handling. You can have options with upper-case names if you quote
them.
robert.haas=# explain (verbose) select 1;
QUERY PLAN
------------------------------------------
Result (cost=0.00..0.01 rows=1 width=4)
Output: 1
(2 rows)
robert.haas=# explain (VERBOSE) select 1;
QUERY PLAN
------------------------------------------
Result (cost=0.00..0.01 rows=1 width=4)
Output: 1
(2 rows)
robert.haas=# explain ("verbose") select 1;
QUERY PLAN
------------------------------------------
Result (cost=0.00..0.01 rows=1 width=4)
Output: 1
(2 rows)
robert.haas=# explain ("VERBOSE") select 1;
ERROR: unrecognized EXPLAIN option "VERBOSE"
LINE 1: explain ("VERBOSE") select 1;
^
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-05-22 14:20:16 | Re: Statistics Import and Export |
| Previous Message | Robert Haas | 2025-05-22 14:14:34 | Re: Reduce "Var IS [NOT] NULL" quals during constant folding |