| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-05-22 15:09:41 |
| Message-ID: | CA+TgmobMQqqTd13BCTyLQf+vB5DKAnpg9LbeHHhkNaENqusKQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 22, 2025 at 10:29 AM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> > I don't think this is really true. It's just standard identifier
> > handling. You can have options with upper-case names if you quote
> > them.
> Sorry for my language. I meant that when you call function
> RegisterExtensionExplainOption(), it make sense if you write parameter
> `option_name` as "debug" or "deBug". On the user side
> case-insensitiveness works correctly, of course. Not sure about side
> effects if one extension will call this routine with "Debug" parameter
> and another one - "debuG".
I guess my point is that this works just like other cases where SQL
identifiers are accessible in C code: they're normally lower-case but
they don't have to be if the user quoted them. I don't think it's
worth adding a comment about that general behavior to this specific
bit of code.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-05-22 15:25:03 | Re: Statistics Import and Export |
| Previous Message | Robert Haas | 2025-05-22 15:07:50 | Re: RFC: Logging plan of the running query |