Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries

> On 31 Jul 2026, at 16:14, Karina Litskevich <litskevichkarina(at)gmail(dot)com> wrote:
>
> I've created a CF entry. I'm sorry it took so long. Life happened.
> https://commitfest.postgresql.org/patch/7082/
>
> On Mon, Jul 13, 2026 at 11:36 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> Simply changing num_entries to int64 leads to the change of the file
>>> header format. I suggest changing num_entries to int64 in PG19 and
>>> later, because it wasn't released yet, and pgss files generated by
>>> another major version are considered to be incompatible anyway. See
>>> the v1 patch attached.
>>
>> Agreed, I think we should make sure to do this once beta2 has shipped for the
>> next beta release.
>>
>
> Daniel, please feel free to become a reviewer and move it to RfC
> if you like the patch.

I'll have another look tomorrow, thanks for the reminder.

> I'm not sure how CFBot works. It's failing to apply the patch, and
> I believe it's because I sent two alternative patches in one mail.
> So I'm resending one patch this time, hoping it will work.

The CFBot will try to apply all the patches in the mail as a patchset, so your
suspicion was correct. It's green in the CFBot now.

--
Daniel Gustafsson