Re: zic: fix PostgreSQL build failure on filesystems without hard link support

Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru> writes:
> Tom Lane писал(а) 2026-07-31 20:07:
>> Yeah, that sounds like the solution with the smallest blast radius.
>> I'll go make it so in a bit. Thanks for the report!

> I have already created and tested a new patch based on this idea.

Oh, I'd already pushed an equivalent fix in win32link.c before
seeing this message.

> It fixes the link() error handling. The patch also fixes dolink()
> on Linux and FreeBSD, since these platforms are affected as well.
> I hope this can be fixed in upstream tzcode.

Eggert already committed something, as per the tz(at)iana(dot)org thread.
I don't want to take a local patch that doesn't match his, and I'm
not really in a big hurry to worry about this on Linux/*BSD anyway.
I think there are few people installing zoneinfo trees on
non-hard-link filesystems on those platforms, else he'd have gotten
pushback sooner. (I didn't research their git history, but I'm
thinking this error behavior has probably been in tzcode for awhile.)
There are even fewer people doing so with Postgres' copy of zic,
because I imagine just about everyone on those platforms uses
--with-system-tzdata instead of a private, often out-of-date zoneinfo
tree. So I'm content to let this go for non-Windows until the next
time we sync our copy of tzcode.

regards, tom lane