| From: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries |
| Date: | 2026-07-31 14:14:57 |
| Message-ID: | CACiT8ibfd8xF9x3xSdeZPBhYsYggZo7nV5E_x5AG+hQnebS2hg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've created a CF entry. I'm sorry it took so long. Life happened.
https://commitfest.postgresql.org/patch/7082/
On Mon, Jul 13, 2026 at 11:36 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > Simply changing num_entries to int64 leads to the change of the file
> > header format. I suggest changing num_entries to int64 in PG19 and
> > later, because it wasn't released yet, and pgss files generated by
> > another major version are considered to be incompatible anyway. See
> > the v1 patch attached.
>
> Agreed, I think we should make sure to do this once beta2 has shipped for the
> next beta release.
>
Daniel, please feel free to become a reviewer and move it to RfC
if you like the patch.
I'm not sure how CFBot works. It's failing to apply the patch, and
I believe it's because I sent two alternative patches in one mail.
So I'm resending one patch this time, hoping it will work.
Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Use-int64-for-number-of-entries-in-pg_stat_statem.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-07-31 14:16:25 | Re: pgstat: Flush some statistics within running transactions, take 2 |
| Previous Message | Tom Lane | 2026-07-31 14:08:54 | Re: zic: fix PostgreSQL build failure on filesystems without hard link support |