From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Addition of %b/backend_type in log_line_prefix of TAP test logs |
Date: | 2025-05-23 14:56:59 |
Message-ID: | 3fdaed3e-6d76-46ab-a57d-958945f5f58b@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2025/05/22 8:58, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Wed, May 21, 2025 at 09:24:26AM +0200, Daniel Gustafsson wrote:
>>> Agreed, and +1 on the change in general.
>
>> Another point perhaps worth considering after a second look: how about
>> pg_ci_base.conf? We have the following line there, exposing this
>> configuration with TEMP_CONFIG:
>> src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '
>
>> The two other ones are:
>> src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a '
>> src/test/regress/pg_regress.c: '%m %b[%p] %q%a '
>
>> Perhaps it would be better to apply the same configuration as the CI
>> by default at the end?
>
> I'd vote for standardizing on pg_regress.c's spelling, as that's got
> the most usage history behind it. I'm unexcited about bloating the
> logs with [%v:%x] --- that's data I've very seldom needed.
+1
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2025-05-23 15:25:27 | Random subscription 021_twophase test failure on kestrel |
Previous Message | Daniel Gustafsson | 2025-05-23 14:49:43 | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |