Re: Addition of %b/backend_type in log_line_prefix of TAP test logs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Date: 2025-05-21 23:58:51
Message-ID: 1420338.1747871931@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, May 21, 2025 at 09:24:26AM +0200, Daniel Gustafsson wrote:
>> Agreed, and +1 on the change in general.

> Another point perhaps worth considering after a second look: how about
> pg_ci_base.conf? We have the following line there, exposing this
> configuration with TEMP_CONFIG:
> src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '

> The two other ones are:
> src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a '
> src/test/regress/pg_regress.c: '%m %b[%p] %q%a '

> Perhaps it would be better to apply the same configuration as the CI
> by default at the end?

I'd vote for standardizing on pg_regress.c's spelling, as that's got
the most usage history behind it. I'm unexcited about bloating the
logs with [%v:%x] --- that's data I've very seldom needed.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-05-22 00:02:25 Re: Minor adjustment to pg_aios output naming
Previous Message Jeff Davis 2025-05-21 23:53:17 Re: Statistics Import and Export