Re: Addition of %b/backend_type in log_line_prefix of TAP test logs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Date: 2025-05-24 00:09:36
Message-ID: aDEOQG1M-N4qfAvz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 23, 2025 at 11:56:59PM +0900, Fujii Masao wrote:
> On 2025/05/22 8:58, Tom Lane wrote:
>> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>>> Another point perhaps worth considering after a second look: how about
>>> pg_ci_base.conf? We have the following line there, exposing this
>>> configuration with TEMP_CONFIG:
>>> src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '
>>
>>> The two other ones are:
>>> src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a '
>>> src/test/regress/pg_regress.c: '%m %b[%p] %q%a '
>>
>>> Perhaps it would be better to apply the same configuration as the CI
>>> by default at the end?
>>
>> I'd vote for standardizing on pg_regress.c's spelling, as that's got
>> the most usage history behind it. I'm unexcited about bloating the
>> logs with [%v:%x] --- that's data I've very seldom needed.
>
> +1

The %v:%x business in log_line_prefix has been introduced in
93d973494613 by Andres. Adding him in CC for comments about the CI
part.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-05-24 00:10:50 Re: PG 18 release notes draft committed
Previous Message Jacob Champion 2025-05-23 21:59:44 Re: pgsql: Make cancel request keys longer