| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |
| Date: | 2025-05-23 14:49:43 |
| Message-ID: | E567A558-446D-4B65-8FF5-82939265EF27@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 20 May 2025, at 11:56, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 20 May 2025, at 04:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> I want to argue for reverting, at least for v18. I do not think that
>> ProcessGetMemoryContextInterrupt is anywhere near release-quality.
>> I found out while poking into Valgrind leak reports that it leaks
>> memory --- and does so in TopMemoryContext.
>
> Ugh, that's indeed a showstopper. Attached is a revert of the feature, I want
> to re-read and re-test before pushing to make sure I didn't miss anything but
> can go ahead with it later today.
This has now been done.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-05-23 14:56:59 | Re: Addition of %b/backend_type in log_line_prefix of TAP test logs |
| Previous Message | Maxim Orlov | 2025-05-23 14:31:01 | Re: Add 64-bit XIDs into PostgreSQL 15 |