Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date: 2016-03-21 13:25:18
Message-ID: 32612.1458566718@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
>> Perl is not my native tongue, but after a little study and some
>> testing on a windows machine, the attached seems to fix the problem.

> I've pushed this, as I would like the buildfarm to be green before
> pushing the latch rework...

Thanks! If Andrew or somebody has a nicer solution, they can improve
this later.

Shouldn't we revert 6f1f34c92b11593e? AFAICS this patch isn't depending
on that, but maybe I miss something.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-03-21 13:33:28 pgsql: Support parallel aggregation.
Previous Message Andres Freund 2016-03-21 11:58:45 pgsql: Properly declare FeBeWaitSet.