Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date: 2016-03-22 01:20:37
Message-ID: 56F09DE5.9020405@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 03/21/2016 09:25 AM, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
>>> Perl is not my native tongue, but after a little study and some
>>> testing on a windows machine, the attached seems to fix the problem.
>> I've pushed this, as I would like the buildfarm to be green before
>> pushing the latch rework...
> Thanks! If Andrew or somebody has a nicer solution, they can improve
> this later.
>

I've reviewed the changes briefly. They seem sane enough, although the
code could do with a little logical reordering.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2016-03-22 01:31:28 Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Previous Message Tom Lane 2016-03-21 22:34:29 pgsql: Improve header output from psql's \watch command.