Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date: 2016-03-21 13:33:58
Message-ID: 20160321133358.GB29022@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2016-03-21 09:25:18 -0400, Tom Lane wrote:
> Shouldn't we revert 6f1f34c92b11593e? AFAICS this patch isn't depending
> on that, but maybe I miss something.

Hm. I'd guess that at least part of it is still required. AddSimpleFrontend()
afaics processes these variables, and I don't think the msvc stuff will
otherwise generate psqlscan.c in the first place. We probably could
move the knowledge to the explicit AddSimpleFrontend('pgbench')
site. But I'm not personally excited about tinkering with it...

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Fetter 2016-03-21 14:35:21 Re: [COMMITTERS] pgsql: Support parallel aggregation.
Previous Message Robert Haas 2016-03-21 13:33:28 pgsql: Support parallel aggregation.