From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. |
Date: | 2016-03-21 09:57:52 |
Message-ID: | 20160321095752.hexfsaxajvfrywsx@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 2016-03-21 22:38:50 +1300, David Rowley wrote:
> On 21 March 2016 at 10:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
> >
> > pgbench now needs to use src/bin/psql/psqlscan.l, but it's not very clear
> > how to fit that into the MSVC build system. If this doesn't work I'm going
> > to need some help from somebody who actually understands those scripts ...
>
> I see this didn't fix the problem :-(
>
> Perl is not my native tongue, but after a little study and some
> testing on a windows machine, the attached seems to fix the problem.
>
> I've never much looked at these script before, but it seems that the
> parsing of the Makefile just assumes that psqlscan.c is in the same
> path as the rest of the stuff. The patch just uses some already
> defined file replace functions to switch the wrong filename out for
> the correct one before the Visual Studios project file is created.
I've pushed this, as I would like the buildfarm to be green before
pushing the latch rework...
Maybe there's a better fix, but I think this is ok.
Thanks!
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2016-03-21 11:39:53 | pgsql: Introduce WaitEventSet API. |
Previous Message | Andres Freund | 2016-03-21 09:57:47 | pgsql: Second attempt at fixing MSVC build for 68ab8e8ba4a471d9. |