Re: Remove redundant variable from transformCreateStmt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove redundant variable from transformCreateStmt
Date: 2021-04-29 15:42:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I'd do it like this. Note I removed an if/else block in addition to
> your changes.

> I couldn't convince myself that this is worth pushing though; either we
> push it to all branches (which seems unwarranted) or we create
> back-patching hazards.

Yeah ... an advantage of the if/else coding is that it'd likely be
simple to extend to cover additional statement types, should we ever
wish to do that. The rendering you have here is nice and compact,
but it would not scale up well.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-04-29 16:15:23 Included xid in restoring reorder buffer changes from disk log message
Previous Message Alvaro Herrera 2021-04-29 15:39:11 Re: default_tablespace doc and partitioned rels