Re: Remove redundant variable from transformCreateStmt

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove redundant variable from transformCreateStmt
Date: 2021-04-29 15:20:06
Message-ID: 20210429152006.GA25241@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I'd do it like this. Note I removed an if/else block in addition to
your changes.

I couldn't convince myself that this is worth pushing though; either we
push it to all branches (which seems unwarranted) or we create
back-patching hazards.

Álvaro Herrera 39°49'30"S 73°17'W

Attachment Content-Type Size
redundant.patch text/x-diff 1.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-04-29 15:39:11 Re: default_tablespace doc and partitioned rels
Previous Message Alvaro Herrera 2021-04-29 15:16:53 Re: Remove post-increment in function quote_identifier of pg_upgrade