Re: PG 18 relnotes and RC1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: PG 18 relnotes and RC1
Date: 2025-08-30 18:17:15
Message-ID: 25884.1756577835@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> If we're okay with items not having credits, then
> add_commit_links.pl's logic for where to put the <ulink>s needs
> improvement. I don't really understand why it's looking for
> parens in the first place -- why isn't the rule simply "put them
> before the first </para> in the item"?

I revised the script to do it that way, as attached. The results
don't change in any of our stable branches. In v18, it makes
this change:

diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index c3e318dab00..c49eb2655eb 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -284,7 +284,7 @@ Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
database clusters using pg_upgrade, it is recommended to reindex all
indexes related to full-text search and pg_trgm after the upgrade.

- <ulink url="&commit_baseurl;fb1a18810f0">&sect;</ulink>
+<ulink url="&commit_baseurl;fb1a18810f0">&sect;</ulink>
</para>
</listitem>

because of the blank line before the </para>, which is not our usual
style and should be removed IMO. (Alternatively, we could change
the $prev_leading_space updating logic to ignore blank lines.)

regards, tom lane

Attachment Content-Type Size
v1-fix-add_commit_links.patch text/x-diff 3.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arseniy Mukhin 2025-08-30 18:41:37 Re: Move block_range_read_stream_cb batchmode comment
Previous Message Andres Freund 2025-08-30 18:14:40 Re: Move block_range_read_stream_cb batchmode comment